Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Code Reference #163

Merged
merged 4 commits into from
Sep 1, 2023
Merged

Update Code Reference #163

merged 4 commits into from
Sep 1, 2023

Conversation

HKevinH
Copy link
Contributor

@HKevinH HKevinH commented Aug 30, 2023 •
edited
Loading

Changes proposed

  • Core/Spells: rework part 4: iterate over effects first Implement far spell queue processing

SOURCE:

  • Thank you for collaborating with the project.
  • For an efficient working methodology.
  • It is obvious to make long pull request, unless it is necessary.
  • A short pull request would be easy to test and approve.

acidmanifesto
acidmanifesto approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@acidmanifesto acidmanifesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me so far. I will get with the others about and see about merging then.

@seobryn seobryn merged commit 808b012 into FirelandsProject:master Sep 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acidmanifesto acidmanifesto acidmanifesto approved these changes

@seobryn seobryn seobryn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HKevinH @seobryn @acidmanifesto